Skip to content

Update json.hpp to v3.9.1#839

Merged
maxgolov merged 5 commits into
masterfrom
maxgolov/json_hpp_391
Apr 24, 2021
Merged

Update json.hpp to v3.9.1#839
maxgolov merged 5 commits into
masterfrom
maxgolov/json_hpp_391

Conversation

@maxgolov
Copy link
Copy Markdown
Contributor

Fixes #833

Integrate the latest Released version of json.hpp from https://github.com/nlohmann/json/releases/tag/v3.9.1

Presently following the existing process, i.e. drop-in a copy of it.

We may later on consider mapping it as submodule under third_party. But not in this PR.

cc: @SahilAshar

Integrate the latest Released version of json.hpp from https://github.com/nlohmann/json/releases/tag/v3.9.1
Copy link
Copy Markdown
Contributor

@mkoscumb mkoscumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Turn off spell-checker for json.hpp (external code)
Fix an issue with new json.hpp
@maxgolov maxgolov marked this pull request as draft April 24, 2021 00:25
@maxgolov maxgolov changed the title Update json.hpp to v3.9.1 [WIP] Update json.hpp to v3.9.1 Apr 24, 2021
@maxgolov maxgolov marked this pull request as ready for review April 24, 2021 00:42
@maxgolov maxgolov changed the title [WIP] Update json.hpp to v3.9.1 Update json.hpp to v3.9.1 Apr 24, 2021
@maxgolov
Copy link
Copy Markdown
Contributor Author

Please ignore the timeout of C/C++ CI on Windows (vs2017) / Build (pull_request) In progress — This check has started..., appears like there is some transient issue with GitHub actions.

@maxgolov maxgolov merged commit ee358c3 into master Apr 24, 2021
@maxgolov maxgolov deleted the maxgolov/json_hpp_391 branch April 24, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

json.hpp compiler errors when compiling on MSVC

2 participants